Avoid assertAlmostEqual for python strings #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Attempted fix for #250
Summary
The
Pose3_TEST.py
test is failing onarm64
with complaints about subtracting strings inassertAlmostEqual
. I believeassertAlmostEqual
is not intended for comparing strings. It can occasionally work if they match exactly (see early return on==
match), but it fails dramatically if they don't match exactly. This changes two instances ofassertAlmostEqual
toassertEqual
for string comparisons.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge