Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assertAlmostEqual for python strings #255

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Attempted fix for #250

Summary

The Pose3_TEST.py test is failing on arm64 with complaints about subtracting strings in assertAlmostEqual. I believe assertAlmostEqual is not intended for comparing strings. It can occasionally work if they match exactly (see early return on == match), but it fails dramatically if they don't match exactly. This changes two instances of assertAlmostEqual to assertEqual for string comparisons.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #255 (012b9fd) into ign-math6 (ac567b5) will not change coverage.
The diff coverage is n/a.

❗ Current head 012b9fd differs from pull request most recent head b3355f0. Consider uploading reports for the commit b3355f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #255   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6347     6347           
==========================================
  Hits            6310     6310           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac567b5...b3355f0. Read the comment docs.

@scpeters scpeters merged commit 211f43d into gazebosim:ign-math6 Sep 30, 2021
@scpeters scpeters deleted the assert_equal_strings branch September 30, 2021 17:59
@scpeters scpeters mentioned this pull request Sep 30, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants