-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport ign-math6] Added examples to tutorials.md.in #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see these tutorials in ign-math6
:
https://github.com/ignitionrobotics/ign-math/tree/ign-math6/tutorials
Did you forget to add the files?
Signed-off-by: Alejandro Hernández <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I pushed some minor changes in 8d49702:
- Added
\page
to the top of each page, so the links from the main tutorials page work - Changed branch
master
toign-math6
on each tutorial - Renamed the tutorials so they don't have
example
in their URLs, which makes them easier to find
Codecov Report
@@ Coverage Diff @@
## ign-math6 #249 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6374 6374
==========================================
Hits 6337 6337
Misses 37 37 Continue to review full report at Codecov.
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
Summary
Fixed tutorial index
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge