Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport ign-math6] Added examples to tutorials.md.in #249

Merged
merged 13 commits into from
Nov 9, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 23, 2021

🦟 Bug fix

Summary

Fixed tutorial index

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde self-assigned this Sep 23, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 23, 2021
@chapulina chapulina added beta Targeting beta release of upcoming collection documentation Improvements or additions to documentation labels Sep 23, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these tutorials in ign-math6:

https://github.com/ignitionrobotics/ign-math/tree/ign-math6/tutorials

Did you forget to add the files?

@chapulina chapulina self-requested a review September 27, 2021 18:35
@chapulina chapulina removed the beta Targeting beta release of upcoming collection label Oct 1, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pushed some minor changes in 8d49702:

  • Added \page to the top of each page, so the links from the main tutorials page work
  • Changed branch master to ign-math6 on each tutorial
  • Renamed the tutorials so they don't have example in their URLs, which makes them easier to find

@chapulina chapulina enabled auto-merge (squash) November 8, 2021 23:41
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #249 (8d49702) into ign-math6 (a4d0b1f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #249   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d0b1f...8d49702. Read the comment docs.

@chapulina chapulina merged commit 33ceeaa into ign-math6 Nov 9, 2021
@chapulina chapulina deleted the ahcorde/fix/tutorial_index branch November 9, 2021 00:02
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants