Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds python interface to triangle. #231

Merged
merged 8 commits into from
Aug 31, 2021
Merged

Conversation

LolaSegura
Copy link
Contributor

@LolaSegura LolaSegura commented Aug 30, 2021

🎉 New feature

Goes on top of #220
Related to #101 #210

Summary

Adds Python interface for Triangle.

Related issues and notes

  • To offer the operator[] functionality in python, the class had to be extended in the interface file (.i file) adding getitem(), calling the operator[] inside.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #231 (5bca988) into ign-math6 (3ea6229) will not change coverage.
The diff coverage is n/a.

❗ Current head 5bca988 differs from pull request most recent head d1fbba1. Consider uploading reports for the commit d1fbba1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #231   +/-   ##
==========================================
  Coverage      99.21%   99.21%           
==========================================
  Files             65       65           
  Lines           6089     6089           
==========================================
  Hits            6041     6041           
  Misses            48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea6229...d1fbba1. Read the comment docs.

@francocipollone
Copy link
Contributor

francocipollone commented Aug 31, 2021

Update this branch now that #220 got merged --> Done

@francocipollone
Copy link
Contributor

I've just fixed conflicts.

Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone marked this pull request as ready for review August 31, 2021 17:17
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chapulina chapulina merged commit 3eae090 into ign-math6 Aug 31, 2021
@chapulina chapulina deleted the LolaSegura/add_triangle branch August 31, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants