Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume below a plane #219

Merged
merged 88 commits into from
Sep 22, 2021
Merged

Volume below a plane #219

merged 88 commits into from
Sep 22, 2021

Commits on Aug 3, 2021

  1. Add volume below primitives

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    56b214e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. fix tests

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    008aa1b View commit details
    Browse the repository at this point in the history
  2. nearly there for boxes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    0e40a5f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Fix boxes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    c18b735 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. use convex hull algo

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    40fa5b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Add overlap method

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    e275ff8 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Finally Box::VolumeBelow() works 🎉

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    dfec15c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. signed volume

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    13f0ade View commit details
    Browse the repository at this point in the history
  2. codecheck

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5cfe42c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Add center of volume recalculation

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    d82a6ba View commit details
    Browse the repository at this point in the history
  2. Add center of volume functions

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    27287dc View commit details
    Browse the repository at this point in the history
  3. codecheck

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    f241019 View commit details
    Browse the repository at this point in the history
  4. Trying to get windows CI to pass

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    61258cd View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Add preliminary cylinder logic.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    69af275 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Add plane transformation

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    3095359 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. fix function return value

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    37b3842 View commit details
    Browse the repository at this point in the history
  2. fix types

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    bbed807 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Preliminary work for cylinders

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    c6c7e00 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. remove unessecary include

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    278dc07 View commit details
    Browse the repository at this point in the history
  2. remove more useless logging

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    f4e70c7 View commit details
    Browse the repository at this point in the history
  3. remove unused transform function.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    11180ee View commit details
    Browse the repository at this point in the history
  4. style fixes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6521336 View commit details
    Browse the repository at this point in the history
  5. 🤦 compilation error

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    532775b View commit details
    Browse the repository at this point in the history
  6. more style fixes.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    a90d11a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a30d0db View commit details
    Browse the repository at this point in the history
  8. Fix docstring

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4d6675d View commit details
    Browse the repository at this point in the history
  9. Revert changes to cylinder since those are not ready yet.

    Cylinders are actually a good model for many maritime vehicles. Moved it to a seperate branch. Will make the PR later.
    
    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    2578996 View commit details
    Browse the repository at this point in the history
  10. more cleanups

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    482f582 View commit details
    Browse the repository at this point in the history
  11. Add triangle test

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4888d99 View commit details
    Browse the repository at this point in the history
  12. Remove redundant function

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    e1985b3 View commit details
    Browse the repository at this point in the history
  13. >.< Doh stray include

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    7f204d4 View commit details
    Browse the repository at this point in the history
  14. remove unused include

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    99589e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. typesafe-ify

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    5ee6f3b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. silence warning

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1c896fa View commit details
    Browse the repository at this point in the history
  2. Codecheck

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    646595f View commit details
    Browse the repository at this point in the history
  3. Flip sign... 🤦

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e8fd7a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Configuration menu
    Copy the full SHA
    6f82675 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    43fd3e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Rename Box::GetIntersections.

    Also removed redundant changes.
    
    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    16289b0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'arjo/volume_below' of github.com:ignitionrobotics/ign-m…

    …ath into arjo/volume_below
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    9ed6254 View commit details
    Browse the repository at this point in the history
  3. Revert *all* changes to cylinder

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    1257aca View commit details
    Browse the repository at this point in the history
  4. fix docs and signature

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7f1f1c8 View commit details
    Browse the repository at this point in the history
  5. Add line test

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6ff1b49 View commit details
    Browse the repository at this point in the history
  6. style fix

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    753b49d View commit details
    Browse the repository at this point in the history
  7. Documentation

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    633dfee View commit details
    Browse the repository at this point in the history
  8. Fix compiler ⚠️

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    165a724 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Added test for Vector3d::Project()

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f5a45fa View commit details
    Browse the repository at this point in the history
  2. Add test for CenterOfVolumeBelow()

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    e7eaad6 View commit details
    Browse the repository at this point in the history
  3. Add Vector(2|3|4)<T>::NaN to easily create invalid vectors (#222)

    Signed-off-by: Louise Poubel <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    chapulina authored and arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9739419 View commit details
    Browse the repository at this point in the history
  4. style

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9fef0d9 View commit details
    Browse the repository at this point in the history
  5. update intersections test

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    5a20d68 View commit details
    Browse the repository at this point in the history
  6. Removed GetPointOnPlane as its unessescary

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    e6e6e65 View commit details
    Browse the repository at this point in the history
  7. fix ⚠️ about signess

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    7189fe0 View commit details
    Browse the repository at this point in the history
  8. Update include/ignition/math/Box.hh

    Co-authored-by: Louise Poubel <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 and chapulina committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d98acb7 View commit details
    Browse the repository at this point in the history
  9. Rename intersections

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8cfbb7d View commit details
    Browse the repository at this point in the history
  10. Rename Vector projection

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    cf438da View commit details
    Browse the repository at this point in the history
  11. Add tolerance argument

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    aed0c6b View commit details
    Browse the repository at this point in the history
  12. Update line to point distance to support points projected beyond the …

    …segment
    
    Signed-off-by: Louise Poubel <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    chapulina authored and arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c835aee View commit details
    Browse the repository at this point in the history
  13. Suggestions to #219

    Signed-off-by: Louise Poubel <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    chapulina authored and arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b1a172f View commit details
    Browse the repository at this point in the history
  14. 🌐 Spherical coordinates: bug fix, docs and sanity checks (#235)

    * Migration guide and LOCAL2
    
    Signed-off-by: Louise Poubel <[email protected]>
    
    Co-authored-by: Carlos Agüero <[email protected]>
    Co-authored-by: Steve Peters <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    3 people authored and arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9979f83 View commit details
    Browse the repository at this point in the history
  15. Adds python interface to Quaternion, Pose3, Matrix3 and Matrix4 (#221)

    * Adds scripting interface to Quaternion and a python test
    * Adds scripting interface to Matrix3 and a python test
    * Adds scripting interface to Pose3 and a python test
    * Solves bug in the Reset() method inside Pose3
    * Adds scripting interface to Matrix4 and a python test
    * Solves bug in the Construct test for Matrix4 class
    * Adds %rename tag to interface files in order to match pep-8 naiming style.
    * Adds a python method to convert from a Matrix3 to a Quaternion.
    * Adds to_quaternion() method to Matrix3.
    
    Signed-off-by: LolaSegura <[email protected]>
    
    * Adds python binding for Quaternion::ToAxis method.
    
    Signed-off-by: Franco Cipollone <[email protected]>
    
    * Matrix3_TEST: improve multiplication test
    
    This changes the test matrices that are multiplied
    togther so that they aren't scalar multiples of each other.
    This confirms non-commutativity in the test.
    
    * Matrix3_TEST.py: add stream out test
    
    Signed-off-by: Steve Peters <[email protected]>
    
    Co-authored-by: Franco Cipollone <[email protected]>
    Co-authored-by: Franco Cipollone <[email protected]>
    Co-authored-by: Steve Peters <[email protected]>
    Signed-off-by: Arjo Chakravarty <[email protected]>
    4 people authored and arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    5c9343f View commit details
    Browse the repository at this point in the history
  16. fixes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    495583d View commit details
    Browse the repository at this point in the history
  17. Rigorous tests and bugfixes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    305d4d4 View commit details
    Browse the repository at this point in the history
  18. Style

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    aba72c1 View commit details
    Browse the repository at this point in the history
  19. more fixes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    0b8c218 View commit details
    Browse the repository at this point in the history
  20. fix compile issues caused by merge

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    acacbb9 View commit details
    Browse the repository at this point in the history
  21. More comprehensive tests and bugfixes for box

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b1a36c0 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    d8bae9a View commit details
    Browse the repository at this point in the history
  23. fix windows warning (I think)

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8e75628 View commit details
    Browse the repository at this point in the history
  24. Add plane intersection in bounds

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9a66163 View commit details
    Browse the repository at this point in the history
  25. style

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4bf9cfb View commit details
    Browse the repository at this point in the history
  26. style

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d0c605d View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. More suggestions to #219

    Signed-off-by: Louise Poubel <[email protected]>
    chapulina committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    d4968df View commit details
    Browse the repository at this point in the history
  2. abs, include

    Signed-off-by: Louise Poubel <[email protected]>
    chapulina committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    9a659fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70aa913 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f8d1a7a View commit details
    Browse the repository at this point in the history
  5. Fixed header

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    95cd4ee View commit details
    Browse the repository at this point in the history
  6. Workaround. Hopefully will make windows happy.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    20d66b1 View commit details
    Browse the repository at this point in the history
  7. Address @SCPETER 's feedback

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1492375 View commit details
    Browse the repository at this point in the history
  8. Address @scpeters feedback about Line3

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    72d7779 View commit details
    Browse the repository at this point in the history
  9. Reverting, because the dividee by zero will never occur

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    e356258 View commit details
    Browse the repository at this point in the history
  10. Added comment

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    b06b483 View commit details
    Browse the repository at this point in the history
  11. Add test cases and assert

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    91a6b43 View commit details
    Browse the repository at this point in the history
  12. Whelps compile error.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    f547e71 View commit details
    Browse the repository at this point in the history
  13. Add docs

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    69b0448 View commit details
    Browse the repository at this point in the history
  14. whitespaces

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    bacd9f9 View commit details
    Browse the repository at this point in the history
  15. More docs fixes

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    4c0bd02 View commit details
    Browse the repository at this point in the history
  16. update scalar value

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    b4f9ddc View commit details
    Browse the repository at this point in the history