-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added secNsecToDuration to helpers functions #158
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #158 +/- ##
=============================================
- Coverage 99.23% 99.22% -0.02%
=============================================
Files 59 59
Lines 5867 5906 +39
=============================================
+ Hits 5822 5860 +38
- Misses 45 46 +1
Continue to review full report at Codecov.
|
homebrew build is failing and looks like osrf/homebrew-simulation#1120 I believe this is failing now since I made |
removing swig dependency in osrf/homebrew-simulation#1124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're at it, how about also adding the other functions that were added for time point? I think most of the code can be reused to avoid duplication.
durationToString
stringToDuration
osrf/homebrew-simulation#1124 is merged, so I expect the homebrew build to be fixed |
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
thank you @scpeters for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
As discussed in the PR gazebosim/gz-sensors#41 (comment) makes sense to use
duration
instead oftime_point
, This function will convert secs and nanoseconds tostd::chrono::steady_clock::duration
Signed-off-by: ahcorde [email protected]