Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum normalized functions #140

Merged
merged 6 commits into from
Aug 1, 2020

Conversation

luccosta
Copy link
Contributor

Resolves #71 .

This implements the functions Sum() and Normalized() in Vector4 API.

It enables:

T sumResult = vec4.Sum();
Vector4 normalVec = vec4.Normalized();

Signed-off-by: Lucas Fernando <[email protected]>
Signed-off-by: Lucas Fernando <[email protected]>
@luccosta luccosta requested a review from scpeters as a code owner July 23, 2020 00:27
@chapulina chapulina added enhancement New feature or request 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jul 23, 2020
@chapulina chapulina requested a review from mjcarroll July 27, 2020 18:28
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some conflicts to resolve before it can land.

@luccosta
Copy link
Contributor Author

@mjcarroll conflict resolved.

@mjcarroll
Copy link
Contributor

Failing Bionic CI is currently expected because of ongoing infrastructure improvements.

@luccosta
Copy link
Contributor Author

@mjcarroll is normal that ignition_math-abichecker-any_to_any-ubuntu_auto-amd64 and ignition_math-ci-pr_any-ubuntu_auto-amd64 still running?

@mjcarroll
Copy link
Contributor

@mjcarroll is normal that ignition_math-abichecker-any_to_any-ubuntu_auto-amd64 and ignition_math-ci-pr_any-ubuntu_auto-amd64 still running?

Not necessarily "normal", but you can check the build queue at build.osrfoundation.org, you can see that it is a bit backed up at the moment.

src/Vector4_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Lucas Fernando <[email protected]>
@chapulina chapulina merged commit 68f1418 into gazebosim:ign-math6 Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants