Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Abs, Dot and AbsDot and respective tests to Vector4 #135

Merged
merged 3 commits into from
Jul 27, 2020

Conversation

luccosta
Copy link
Contributor

Resolves #71 .

This implements the functions Abs(), Dot(Vector4) and AbsDot(Vector4) in Vector4 API, similar to the existing same functions in Vector3.

It enables Vector4 objects to perform:

vec4.Abs();
vec4_a.Dot(vec4_b);
vec4_a.AbsDot(vec4_b);

Did all checks and tests.

@luccosta luccosta requested a review from scpeters as a code owner July 15, 2020 23:55
@chapulina chapulina added enhancement New feature or request 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jul 16, 2020
@luccosta
Copy link
Contributor Author

luccosta commented Jul 22, 2020

After merge ign-math6 backwards, locally everything is running ok, but the Ubuntu Bionic CI is getting:

Unexpected input(s) 'script-after-make', valid inputs are ['entryPoint', 'args', 'github_token', 'apt-dependencies', 'codecov-token', 'cmake-args']

And I'm not finding anything about this.

Same happening on ruby PR #137 .

@chapulina
Copy link
Contributor

Unexpected input(s) 'script-after-make'

Don't worry, you can ignore this. It's a problem with our infrastructure.

@luccosta luccosta requested a review from mjcarroll July 23, 2020 22:31
@mjcarroll mjcarroll merged commit d50d094 into gazebosim:ign-math6 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants