Added feedback

Signed-off-by: ahcorde <[email protected]>
gazebosim · Nov 25, 2021 · 630046a · 630046a
1 parent dc6176a
commit 630046a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/include/ignition/math/Vector2.hh b/include/ignition/math/Vector2.hh
@@ -18,6 +18,7 @@
 #define IGNITION_MATH_VECTOR2_HH_
 
 #include <algorithm>
+#include <cmath>
 #include <limits>
 
 #include <ignition/math/Helpers.hh>
@@ -106,12 +107,12 @@ namespace ignition
       /// \brief Normalize the vector length
       public: void Normalize()
       {
-        double d = this->Length();
+        T d = this->Length();
 
-        if (!equal<T>(static_cast<T>(d), static_cast<T>(0.0)))
+        if (!equal<T>(d, static_cast<T>(0.0)))
         {
-          this->data[0] /= static_cast<T>(d);
-          this->data[1] /= static_cast<T>(d);
+          this->data[0] /= d;
+          this->data[1] /= d;
         }
       }
 
@@ -128,8 +129,8 @@ namespace ignition
       /// \return the result
       public: Vector2 Round()
       {
-        this->data[0] = static_cast<T>(nearbyint(this->data[0]));
-        this->data[1] = static_cast<T>(nearbyint(this->data[1]));
+        this->data[0] = std::nearbyint(this->data[0]);
+        this->data[1] = std::nearbyint(this->data[1]);
         return *this;
       }
 

diff --git a/include/ignition/math/Vector3.hh b/include/ignition/math/Vector3.hh
@@ -163,9 +163,9 @@ namespace ignition
       /// \return the result
       public: Vector3 Round()
       {
-        this->data[0] = static_cast<T>(nearbyint(this->data[0]));
-        this->data[1] = static_cast<T>(nearbyint(this->data[1]));
-        this->data[2] = static_cast<T>(nearbyint(this->data[2]));
+        this->data[0] = std::nearbyint(this->data[0]);
+        this->data[1] = std::nearbyint(this->data[1]);
+        this->data[2] = std::nearbyint(this->data[2]);
         return *this;
       }
 

diff --git a/include/ignition/math/Vector4.hh b/include/ignition/math/Vector4.hh
@@ -18,6 +18,7 @@
 #define IGNITION_MATH_VECTOR4_HH_
 
 #include <algorithm>
+#include <cmath>
 #include <limits>
 
 #include <ignition/math/Matrix4.hh>
@@ -121,10 +122,10 @@ namespace ignition
       /// \brief Round to near whole number.
       public: void Round()
       {
-        this->data[0] = static_cast<T>(nearbyint(this->data[0]));
-        this->data[1] = static_cast<T>(nearbyint(this->data[1]));
-        this->data[2] = static_cast<T>(nearbyint(this->data[2]));
-        this->data[3] = static_cast<T>(nearbyint(this->data[3]));
+        this->data[0] = std::nearbyint(this->data[0]);
+        this->data[1] = std::nearbyint(this->data[1]);
+        this->data[2] = std::nearbyint(this->data[2]);
+        this->data[3] = std::nearbyint(this->data[3]);
       }
 
       /// \brief Get a rounded version of this vector