Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where address of local variable was returned #252

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

This patch returns a malloc'd copy instead.

This was introduced in #218. homebrew had a warning https://build.osrfoundation.org/job/gz_launch-ci-pr_any-homebrew-amd64/24/clang/, but our Linux CI was green: https://build.osrfoundation.org/job/gz_launch-ci-pr_any-focal-amd64/16/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from nkoenig as a code owner April 4, 2024 19:07
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.22%. Comparing base (17835ca) to head (176b9f6).

Files Patch % Lines
src/cmd/gz.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           gz-launch6     #252   +/-   ##
===========================================
  Coverage       56.22%   56.22%           
===========================================
  Files               4        4           
  Lines             418      418           
===========================================
  Hits              235      235           
  Misses            183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 5938a17 into gazebosim:gz-launch6 Apr 5, 2024
10 of 12 checks passed
@azeey azeey deleted the fix_dangling_address_return branch April 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants