Only set shadow texture size if configured by the user in the SDFormat file #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t file Signed-off-by: Addisu Z. Taddese <[email protected]>
jennuine
approved these changes
Sep 16, 2024
iche033
approved these changes
Sep 16, 2024
iche033
pushed a commit
that referenced
this pull request
Sep 25, 2024
…t file (#642) Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gazebo_test_cases#1604
Summary
The default shadow texture size being set even in Ogre1, for which we don't have that capability implemented. This changes the texture size to an optional so that only if the shadow texture parameter is specified in the SDFormat file will it try to call
SetShadowTextureSize.Test It
gazebosim/gz-sim#2586 has changed the
dem_monterey_bay.sdffile to useogre2, so you'll need to change it back toogreto test this. With this PR, it should not have an error message.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.