Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Migrate config and log directories : gz-gui #454

Merged
merged 2 commits into from
Apr 7, 2023
Merged

ign -> gz Migrate config and log directories : gz-gui #454

merged 2 commits into from
Apr 7, 2023

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon changed the title ign -> gz Partial Docs and Project Name Followups : gz-gui ign -> gz Migrate config and log directories : gz-gui Aug 4, 2022
@methylDragon methylDragon mentioned this pull request Aug 4, 2022
Open
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited
Loading

Codecov Report

Merging #454 (c745e39) into gz-gui7 (b90acee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c745e39 differs from pull request most recent head bc78bf5. Consider uploading reports for the commit bc78bf5 to get more accurate results

@@             Coverage Diff             @@
##           gz-gui7     #454      +/-   ##
===========================================
+ Coverage    69.11%   69.13%   +0.01%     
===========================================
  Files           44       44              
  Lines         4919     4921       +2     
===========================================
+ Hits          3400     3402       +2     
  Misses        1519     1519
Impacted Files Coverage Δ
src/Application.cc 85.93% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chapulina
chapulina reviewed Aug 4, 2022
View reviewed changes
src/Application.cc Show resolved Hide resolved
src/Application.cc Show resolved Hide resolved
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Aug 5, 2022
@nkoenig
Copy link
Contributor

nkoenig commented Aug 23, 2022

@methylDragon , did you want to target a different branch?

@chapulina chapulina changed the base branch from main to gz-gui7 August 26, 2022 16:33
@chapulina
Copy link
Contributor

chapulina commented Aug 26, 2022 •
edited
Loading

Yeah @methylDragon , let's rebase this onto gz-gui7

@AndrejOrsula AndrejOrsula mentioned this pull request Sep 16, 2022
Closed
2 tasks
@azeey azeey self-requested a review November 14, 2022 19:53
@azeey
Copy link
Contributor

azeey commented Apr 7, 2023

I've rebased this to gz-gui7 and removed commit 1551520 that belonged in main and was causing conflicts.

@azeey
Copy link
Contributor

azeey commented Apr 7, 2023

The Github Actions failures also happen in on the gz-gui7 branch (https://github.com/gazebosim/gz-gui/actions/runs/4389109614/jobs/7686333715) and the hombrew failure is a know issue #503. Merging!

@azeey azeey merged commit 1f0cc2c into gz-gui7 Apr 7, 2023
@azeey azeey deleted the config_and_log_migration branch April 7, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina left review comments

@nkoenig nkoenig nkoenig approved these changes

@azeey azeey azeey approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methylDragon @nkoenig @chapulina @azeey