-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a filter to the plugin menu #277
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #277 +/- ##
=========================================
Coverage 66.46% 66.46%
=========================================
Files 25 25
Lines 2949 2949
=========================================
Hits 1960 1960
Misses 989 989 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently, after you open the plugin menu, the text field needs to be clicked to begin typing. Is there a way to set it so that you can start typing in the text field automatically after clicking the plugin menu?
Signed-off-by: Louise Poubel <[email protected]>
…botics/ign-gui into chapulina/3/menu_filter Signed-off-by: Louise Poubel <[email protected]>
Great idea, done in 84fbfe7 |
I have the impression that before this PR, the plugins used to be alphabetically sorted in the list. Now they appear in a random order and it's even larger mess than before. |
humm yeah you're right, they used to be alphabetically ordered since #71. I'm reopening gazebosim/gz-sim#175 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
🎉 New feature
Closes gazebosim/gz-sim#821
Summary
Now that we have so many GUI plugins, it can be tough for users to get to the plugin they want, or to discover existing plugins.
This PR adds a field to the plugin menu so the user can filter plugins by name. This should help getting to plugins more easily.
Test it
Load
ign gui
orign gazebo
, open the menu, and filter away:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸