Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify units for the DEM classes #595

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Apr 20, 2024

📖 Docs Improvement

Summary

  • Avoid users asking whether the height and elevation functions are the same
  • Match common conventions like in GDAL to refer to things in "raster" coordinates with "pixels" indicating each point on a DEM
  • Reference: https://gdal.org/tutorials/raster_api_tut.html

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Avoid users asking whether the height and elevation functions are the
  same
* Match common conventions like in GDAL to refer to things in "raster"
  coordinates with "pixels" indicating each point on a DEM
* https://gdal.org/tutorials/raster_api_tut.html

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 requested a review from marcoag as a code owner April 20, 2024 06:09
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 20, 2024
@ahcorde ahcorde merged commit 1e5820a into gazebosim:gz-common5 Apr 22, 2024
11 of 13 checks passed
@Ryanf55 Ryanf55 deleted the clarify-dem-units branch April 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants