Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-common4 ➡️ gz-common5 #572

Merged
merged 13 commits into from
Jan 18, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jan 18, 2024

➡️ Forward port

Port ign-common4 ➡️ gz-common5

Branch comparison: gz-common5...ign-common4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

zaidhaan and others added 13 commits May 22, 2023 08:42
Signed-off-by: Michael Carroll <[email protected]>
* fix: Don't recursively call init if log directories can not be created.

If there is no permission to create the log directories, the FileLogger
will call itself recutsive, as is used ignerr for logging the error,
which will call FileLogger::Init again.

This commit fixed this, by using std::cerr for the log output in
FileLogger::Init.


Signed-off-by: Janosch Machowinski <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️  ign-common4
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️  ign-common4
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from marcoag as a code owner January 18, 2024 21:01
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jan 18, 2024
@azeey
Copy link
Contributor Author

azeey commented Jan 18, 2024

@mjcarroll I couldn't properly port #561 since a lot has changed. Is it needed for gz-common5?

@mjcarroll
Copy link
Contributor

No, it's no longer necessary as we changed how the filesystem functions warn when switching to std::filesystem.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c948a9d) 83.65% compared to head (2d06bf7) 83.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-common5     #572   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10273    10273           
===========================================
  Hits             8594     8594           
  Misses           1679     1679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 0b8428a into gazebosim:gz-common5 Jan 18, 2024
15 checks passed
@azeey azeey deleted the 4_to_5 branch January 18, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants