-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ign-common4 ➡️ gz-common5 #572
Conversation
Signed-off-by: Zaidhaan Hussain <[email protected]>
Signed-off-by: Angelo Elias Dal Zotto <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
* fix: Don't recursively call init if log directories can not be created. If there is no permission to create the log directories, the FileLogger will call itself recutsive, as is used ignerr for logging the error, which will call FileLogger::Init again. This commit fixed this, by using std::cerr for the log output in FileLogger::Init. Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️ ign-common4
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️ ign-common4
Signed-off-by: Addisu Z. Taddese <[email protected]>
@mjcarroll I couldn't properly port #561 since a lot has changed. Is it needed for gz-common5? |
No, it's no longer necessary as we changed how the filesystem functions warn when switching to std::filesystem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-common5 #572 +/- ##
===========================================
Coverage 83.65% 83.65%
===========================================
Files 90 90
Lines 10273 10273
===========================================
Hits 8594 8594
Misses 1679 1679 ☔ View full report in Codecov by Sentry. |
➡️ Forward port
Port
ign-common4
➡️gz-common5
Branch comparison: gz-common5...ign-common4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)