Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ignerr with gzerr #547

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Replace ignerr with gzerr #547

merged 1 commit into from
Oct 28, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 27, 2023

🦟 Bug fix

Summary

ignerr -> gzerr

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from marcoag as a code owner October 27, 2023 23:55
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #547 (55995ce) into gz-common5 (3742a5a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 55995ce differs from pull request most recent head 413aad6. Consider uploading reports for the commit 413aad6 to get more accurate results

@@             Coverage Diff             @@
##           gz-common5     #547   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10272    10272           
===========================================
  Hits             8593     8593           
  Misses           1679     1679           
Files Coverage Δ
graphics/src/AssimpLoader.cc 88.29% <100.00%> (ø)

@mjcarroll mjcarroll merged commit 983a1eb into gz-common5 Oct 28, 2023
18 checks passed
@mjcarroll mjcarroll deleted the ign_gz branch October 28, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants