Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Inits units tests for fbx and glTF2 #385

Merged

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Jul 2, 2022

AssimpLoader_TEST.cc updated to include basic unit tests for fbx and glb mesh files. New mesh files uploaded.

AssimpLoader_TEST.cc updated to include basic
unit tests for fbx and glb mesh files. New
mesh files uploaded.

Signed-off-by: Onur Berk Tore <[email protected]>
@onurtore onurtore requested a review from mjcarroll as a code owner July 2, 2022 20:31
@onurtore
Copy link
Contributor Author

onurtore commented Jul 2, 2022

Hi @luca,
This commit includes just basic unit tests for the fbx and gltf files. The tests are failing and I will work on that.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@luca-della-vedova
Copy link
Member

luca-della-vedova commented Jul 5, 2022

CI will complain even if your tests pass because of the missing assimp dependency. I guess can just ping here when they are passing and this is ready for review?

@luca-della-vedova
Copy link
Member

Merging first, will fix the tests on the main branch

@luca-della-vedova luca-della-vedova merged commit 8fe6b91 into gazebosim:luca/assimp_sandbox Jul 20, 2022
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants