Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept arbitrary capitalization for coverage build type (backport #435) #439

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 22, 2024

🦟 Bug fix

Summary

When running cmake -DCMAKE_BUILD_TYPE=coverage (which most of our CI does), gz-cmake generates a warning

Code coverage results with an optimized (non-Debug) build may be misleading

This is only because we are specifically looking for Coverage, with uppercase C. This patch makes it possible to pass any capitalization of the word.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #435 done by [Mergify](https://mergify.com).

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 916a917)
@mergify mergify bot requested review from j-rivero and scpeters as code owners July 22, 2024 15:08
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 22, 2024
@azeey azeey merged commit e08595c into ign-cmake2 Jul 22, 2024
10 checks passed
@azeey azeey deleted the mergify/bp/ign-cmake2/pr-435 branch July 22, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant