Add macros for generating pybind11 bindings #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #215
Summary
This adds CMake macros to remove code duplication for creating pybind11 bindings.
The only problem that occurs is that it destroys the used structure in
CMakeLists.txt
(e.g. for gz-math):The other two macros are fine:
src/CMakeLists.txt
:Test it
/ws/install
mkdir build && cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/ws/install/
make -j && make install
source /ws/install/setup.bash
, changeCMakeLists.txt
to usegz-cmake4
and the new macrosmkdir build && cd build && cmake .. && make -j
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸