Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake macro to find the assimp library #278

Merged
merged 12 commits into from
Jul 26, 2022
Merged

CMake macro to find the assimp library #278

merged 12 commits into from
Jul 26, 2022

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Jul 13, 2022

🎉 New feature

Summary

This PR adds support to gz_find_package for finding the assimp package including the ability to specify a version.

Test it

It can be tested with the upstream PR in gz-common, try to build it with and without this branch and check that it fails without.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@luca-della-vedova luca-della-vedova marked this pull request as draft July 20, 2022 03:13
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
@luca-della-vedova luca-della-vedova marked this pull request as ready for review July 20, 2022 10:26
@chapulina chapulina added the enhancement New feature or request label Jul 23, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally on Linux. On Focal it detects a version below 5.2.0 and on Jammy it's above. We could try out macOS and Windows with some custom branches before merging, but since this change is quite isolated, we're close to feature freeze, and it targets an unstable branch, I think it's worth merging it and we can iterate on future PRs if needed.

@chapulina chapulina merged commit 899a214 into main Jul 26, 2022
@chapulina chapulina deleted the luca/find_assimp branch July 26, 2022 16:33
@chapulina
Copy link
Contributor

Triggered nightlies:

  • Jammy Build Status
  • Focal Build Status

@onurtore
Copy link

onurtore commented Aug 4, 2022

Tested locally, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants