Project option: NO_IGNITION_PREFIX #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow projects (like sdformat) to use ignition-cmake2 without requiring the project name to start with ignition-. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
Gazebo 1️1️
8 tasks
adlarkin
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Changes look good, but I have a few questions about some of the empty files:
examples/no_ignition_prefix/README.mdis empty. Would you mind updating it to mention the purpose of this example? You could point to theNO_IGNITION_PREFIXoption in the example project'sCMakeLists.txt, and also point out that the tarball produced shouldn't have theignitionprefix.- There are a few empty
CMakeLists.txtfiles. Can they be removed?
believe it or not, all of the empty files, including README.md are required. Try removing one, and you'll see build errors. I will add a description to the example README.md as you suggest |
Signed-off-by: Steve Peters <[email protected]>
|
adlarkin
approved these changes
Nov 5, 2021
8 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
srmainwaring
pushed a commit
to srmainwaring/gz-cmake
that referenced
this pull request
Mar 1, 2022
* IgnConfigureProject: add NO_IGNITION_PREFIX option This would allow projects (like sdformat) to use ignition-cmake2 without requiring the project name to start with ignition-. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Helps with gazebosim/sdformat#181, split out from #190
Summary
Currently all cmake projects that use
IgnConfigureProjectare required to have a cmake project name that starts withignition-. We would like to useign-cmake2withlibsdformat, but its cmake project name and include paths don't follow this pattern. This pull request adds an option toIgnConfigureProjectto allow more flexibility:NO_IGNITION_PREFIX: option that prevents theignition-prefix from being prepended to the cmake project name.Test it
Look at the
examples/no_ignition_prefixfolder and build withcmake .. -DBUILDSYSTEM_TESTING=ON && make -j. The generated tarball name is confirmed to not start withignition-Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge