Special case for ogre2.2 on Windows #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏢 edifice
Signed-off-by: Michael Carroll <[email protected]>
|
Is there a CI test run that we can refer to? |
Not really, this also requires the ogre2.2 branch in ign-rendering. I have tested it locally on my Windows machine. |
Signed-off-by: Michael Carroll <[email protected]>
chapulina
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
We're having a hard time setting up custom CI for this, so let's yolo merge and test it with gazebosim/gz-rendering#272. It shouldn't break anyone else, so in the worst case, it doesn't improve anything.
|
I will test it tomorrow |
srmainwaring
pushed a commit
to srmainwaring/gz-cmake
that referenced
this pull request
Mar 1, 2022
* Special case for ogre2.2 on Windows Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes finding osrf vcpkg ogre2.2 on Windows.
Signed-off-by: Michael Carroll [email protected]