Enable make codecheck for ign-cmake #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
github-actions
bot
added
🏢 edifice
adlarkin
reviewed
Dec 22, 2020
Signed-off-by: Louise Poubel <[email protected]>
adlarkin
approved these changes
Dec 22, 2020
| @@ -0,0 +1,16 @@ | |||
| /* | |||
| * Copyright (C) 2018 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
This is probably a nit, but should we update the year on these new licenses to 2020? Or does it not really matter?
There was a problem hiding this comment.
I tried to keep the year of when the files were created (note that some files were renamed in 2019).
Also, if you check the cc files for those examples, they have copyrights that say 2018. So I think this is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #134