Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert file name changes to fix menu and links for macOS installation #485

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 14, 2024

🦟 Bug fix

Summary

In #414 the file names install_osx.md and install_osx_src.md were changed, which broke links and side menu as shown in the picture below. Notice the missing menu item for macOS installation.

image

This reverts the file name change while keeping the rest of the changes in the PR. We can eventually rename the files as well, but that would require creating redirects so we don't break existing references on the internet.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mabelzhang as a code owner August 14, 2024 19:51
@azeey azeey requested a review from iche033 August 14, 2024 19:51
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 14, 2024
@azeey azeey merged commit c5a131b into gazebosim:master Aug 14, 2024
6 checks passed
@azeey azeey deleted the fix_macos_install_links branch August 14, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants