Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions on checking if sim runs with ogre 1.x #478

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 5, 2024

🦟 Bug fix

Summary

The instructions for checking if sim runs with ogre 1.x is outdated. The lights.sdf world used to have gui configurations to use the ogre render engine but that was removed in gazebosim/gz-sim#278. Now the user has to explicitly specify the --render-engine ogre arg to run with ogre 1.x.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Aug 5, 2024
@azeey azeey merged commit e52b489 into master Aug 6, 2024
6 checks passed
@azeey azeey deleted the troubleshoot_ogre1 branch August 6, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants