Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canonical link generated by sphinx #460

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 17, 2024

🦟 Bug fix

Summary

A trailing slash is necessary for page links to be appended correctly. Currently, for example, https://gazebosim.org/docs/harmonic/sensors/ has the canonical link set to https://gazebosim.org/docs/latestsensors/ instead of https://gazebosim.org/docs/latest/sensors/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

A trailing slash is necessary for page links to be appended correctly

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mabelzhang as a code owner July 17, 2024 21:13
@azeey azeey merged commit ef216d6 into gazebosim:master Jul 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants