Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the ROS and Fortress bridge #430

Merged

Conversation

Mohammadreza-Beygifard
Copy link
Contributor

@Mohammadreza-Beygifard Mohammadreza-Beygifard commented Feb 14, 2024

🦟 Bug fix

Fixes #429

Summary

I am updating the documentation of the ROS2 <-> Gazezebo fortress bridge. By mistake in the documentation the command ros_ign_bridge was used; However, the correct command to create the bridge is ros2 run ros_gz_bridge parameter_bridge. For more details, please refer to the issue.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have one minor comment.

Also, can you fix the conflict?

fortress/ros2_integration.md Outdated Show resolved Hide resolved
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Mohammadreza Beygifard <[email protected]>
@Mohammadreza-Beygifard
Copy link
Contributor Author

@azeey I have addressed the conflict and everything looks good now, please inform me if there is anything else I can do. Best!

@azeey azeey merged commit fa5a40c into gazebosim:master Apr 4, 2024
1 check passed
@pxalcantara
Copy link
Contributor

@azeey How are you? just to understand the process. When will be made the next deploy of the documentation and this update will be implemented?

@Mohammadreza-Beygifard congratulations and thanks for your contribution, I had the same problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong ROS2 bridge in Fortress ros integration documentation
3 participants