Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vendor installation support for Jazzy and Rolling #87

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

sauk2
Copy link
Collaborator

@sauk2 sauk2 commented Oct 1, 2024

Closes #79

Summary

This PR introduces a check against the input list of ROS 2 distributions before installing Gazebo. In case of availability of packages as vendor installation, ros_gz is installed instead of Gazebo.

@sauk2 sauk2 requested a review from j-rivero October 1, 2024 11:07
__test__/main.test.ts Outdated Show resolved Hide resolved
@sauk2
Copy link
Collaborator Author

sauk2 commented Oct 5, 2024

Thanks for the feedback! I have made the changes you suggested.

@sauk2 sauk2 requested a review from j-rivero October 5, 2024 12:35
@j-rivero
Copy link
Contributor

j-rivero commented Oct 7, 2024

Thanks for the feedback! I have made the changes you suggested.

Fantastic, we need to add a bit of documentation to the README file so people know that vendor packages are going to be installed starting with Jazzy. The pairings appear in https://gazebosim.org/docs/ionic/ros_installation/#gazebo-packages-for-ubuntu and the general description is at https://gazebosim.org/docs/ionic/ros2_gz_vendor_pkgs/

@sauk2
Copy link
Collaborator Author

sauk2 commented Oct 7, 2024

Fantastic, we need to add a bit of documentation to the README file so people know that vendor packages are going to be installed starting with Jazzy. The pairings appear in https://gazebosim.org/docs/ionic/ros_installation/#gazebo-packages-for-ubuntu and the general description is at https://gazebosim.org/docs/ionic/ros2_gz_vendor_pkgs/

I have updated the documentation with that information

README.md Outdated Show resolved Hide resolved
@j-rivero
Copy link
Contributor

I have updated the documentation with that information

A added a bit more of info and an example so people can understand what is the option about. Good to go ! Great work !

@j-rivero j-rivero merged commit a30dfaf into gazebo-tooling:main Oct 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ROS Gazebo vendor packages
2 participants