Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign ➡️ gz] Clone directories #112

Closed
wants to merge 2 commits into from
Closed

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 7, 2022

This PR is migrating only the directory name when a repository is cloned.

Commands run:

sed -i 's/ign-\(.*\):/gz-\1:/g' *.*
sed -i 's/gz-gazebo/gz-sim/g' *.*

Tests

This may affect CI, I'll run some tests before opening for review.

  • Windows CI (which uses gazebodistro via vcs + colcon): Build Status

sed -i 's/ign-\(.*\):/gz-\1:/g' *.*sed -i 's/gz-gazebo/gz-sim/g' *.*

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the title [ign ➡️ gz] Clone directories" [ign ➡️ gz] Clone directories Jun 7, 2022
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to need to migrate the branch names eventually.. 🤔

@chapulina
Copy link
Contributor Author

Are we going to need to migrate the branch names eventually..

Not the ones that are currently stable. Nor the existing tags. That's to keep backwards compatibility. But new branches and tags will be gz.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2022

Let's follow in #117

@j-rivero j-rivero closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants