Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for system installed ogre-next #4

Closed
srmainwaring opened this issue May 13, 2024 · 1 comment · Fixed by #5
Closed

Add check for system installed ogre-next #4

srmainwaring opened this issue May 13, 2024 · 1 comment · Fixed by #5

Comments

@srmainwaring
Copy link
Contributor

Similar to gazebo-release/gz_dartsim_vendor#4

Add a check for the system installed version of ogre-next before calling ament_vendor. For example on macOS the appropriate ogre-next libraries are available from brew:

$ brew info ogre2.3  
==> osrf/simulation/ogre2.3: stable 2.3.1, HEAD
Scene-oriented 3D engine written in c++
https://www.ogre3d.org/
Installed
/opt/homebrew/Cellar/ogre2.3/2.3.1_2 (860 files, 16.6MB) *
  Built from source on 2024-03-04 at 12:23:52
From: https://github.com/osrf/homebrew-simulation/blob/HEAD/Formula/ogre2.3.rb
License: MIT
==> Dependencies
Build: cmake ✔
Required: doxygen ✔, freeimage ✔, freetype ✔, libx11 ✔, libzzip ✔, rapidjson ✔, tbb ✔
==> Options
--HEAD
	Install HEAD version

A suggested change (with debug messages) in this branch: https://github.com/srmainwaring/gz_ogre_next_vendor/tree/rolling-macos.

The change introduces a dependency on gz-cmake(3). Using the gz-cmake-vendor version does not seem to work, which is why gz-cmake3 has been hardcoded. This would need to be resolved before adopting.

@oysstu
Copy link
Contributor

oysstu commented Aug 6, 2024

Same thing on archlinux. It's better to leverage the distro package instead of having to maintain and compile another source installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants