Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for system installed dart #4

Closed
srmainwaring opened this issue May 13, 2024 · 2 comments · Fixed by #6
Closed

Add check for system installed dart #4

srmainwaring opened this issue May 13, 2024 · 2 comments · Fixed by #6

Comments

@srmainwaring
Copy link
Contributor

Feature request

Add a check for the system installed version of DART before calling ament_vendor. For example on macOS the appropriate DART libraries are available from brew:

brew info dartsim
==> dartsim: stable 6.13.2 (bottled)
Dynamic Animation and Robotics Toolkit
https://dartsim.github.io/
Installed
/opt/homebrew/Cellar/dartsim/6.13.2_3 (1,081 files, 48.0MB) *
  Poured from bottle on 2024-05-08 at 23:03:42
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/d/dartsim.rb
License: BSD-2-Clause
==> Dependencies
Build: cmake ✔, pkg-config ✔
Required: assimp ✔, bullet ✔, eigen ✔, fcl ✔, flann ✔, fmt ✔, ipopt ✔, libccd ✔, nlopt ✔, ode ✔, open-scene-graph ✔, spdlog ✔, tinyxml2 ✔, urdfdom ✔

and do not need to be built again as part of the vendor build.

A suggested change (with debug messages) in this branch: https://github.com/srmainwaring/gz_dartsim_vendor/tree/rolling-macos

@azeey
Copy link
Collaborator

azeey commented May 21, 2024

That looks good to me. Can you create a PR?

@oysstu
Copy link
Contributor

oysstu commented Aug 6, 2024

@srmainwaring Are you planning on following this up with a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants