Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #205

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Update README.md #205

merged 1 commit into from
Oct 16, 2024

Conversation

gauthierpetetin-test
Copy link
Owner

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
1. What is the reason for the change?
2. What is the improvement/solution?

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin-test gauthierpetetin-test merged commit efb8f42 into main Oct 16, 2024
2 of 3 checks passed
@gauthierpetetin-test gauthierpetetin-test added release-12.13.166 Issue or pull request that will be included in release 12.13.166 external-contributor Issue or PR created by user outside MetaMask organisation labels Oct 16, 2024
@gauthierpetetin-test gauthierpetetin-test deleted the Version-v6.5.4 branch October 16, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Issue or PR created by user outside MetaMask organisation release-12.13.166 Issue or pull request that will be included in release 12.13.166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant