Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #180

wants to merge 1 commit into from

Conversation

gauthierpetetin-test
Copy link
Owner

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
1. What is the reason for the change?
2. What is the improvement/solution?

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin-test gauthierpetetin-test added the external-contributor Issue or PR created by user outside MetaMask organisation label Jun 4, 2024
gauthierpetetin
gauthierpetetin reviewed Sep 9, 2024
View reviewed changes
README.md
@@ -2,3 +2,5 @@
This is a test repo for experiments.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment 1

gauthierpetetin
gauthierpetetin reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished my review

README.md
@@ -2,3 +2,5 @@
This is a test repo for experiments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment 2

README.md
@@ -2,3 +2,5 @@
This is a test repo for experiments.

This is a test branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment 3

README.md
@@ -2,3 +2,5 @@
This is a test repo for experiments.

This is a test branch.

Test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment 4

@gauthierpetetin-test
Copy link
Owner Author

Issue comment 1

gauthierpetetin
gauthierpetetin reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment 1

gauthierpetetin
gauthierpetetin requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment 2

gauthierpetetin
gauthierpetetin approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve 1

@gauthierpetetin gauthierpetetin self-requested a review September 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauthierpetetin gauthierpetetin Awaiting requested review from gauthierpetetin

Assignees
No one assigned
Labels
external-contributor Issue or PR created by user outside MetaMask organisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauthierpetetin-test @gauthierpetetin