fix(action): small refactor to improve readability

gauthierpetetin-test · Jul 15, 2024 · 0610006 · 0610006
1 parent b8a261e
commit 0610006
Showing 1 changed file with 44 additions and 35 deletions.
diff --git a/.github/scripts/check-template-and-add-labels.ts b/.github/scripts/check-template-and-add-labels.ts
@@ -228,14 +228,15 @@ function extractRegressionStageFromBugReportIssueBody(
   const match = body.match(detectionStageRegex);
   const extractedAnswer = match ? match[1].trim() : undefined;
 
-  if (extractedAnswer === 'On the development branch') {
-    return RegressionStage.Development;
-  } else if (extractedAnswer === 'During release testing') {
-    return RegressionStage.Testing;
-  } else if (extractedAnswer === 'In production') {
-    return RegressionStage.Production;
-  } else {
-    return undefined;
+  switch (extractedAnswer) {
+    case 'On the development branch':
+      return RegressionStage.Development;
+    case 'During release testing':
+      return RegressionStage.Testing;
+    case 'In production':
+      return RegressionStage.Production;
+    default:
+      return undefined;
   }
 }
 
@@ -275,33 +276,8 @@ async function addRegressionLabelToIssue(
   );
 
   // Craft regression label to add
-  let regressionLabel: Label;
-  if (regressionStage === RegressionStage.Development) {
-    regressionLabel = {
-      name: `regression-develop`,
-      color: '5319E7', // violet
-      description: `Regression bug that was found on development branch, but not yet present in production`,
-    };
-  } else if (regressionStage === RegressionStage.Testing) {
-    regressionLabel = {
-      name: `regression-RC-${releaseVersion || '*'}`,
-      color: '744C11', // orange
-      description: releaseVersion ? `Regression bug that was found in release candidate (RC) for release ${releaseVersion}` : `TODO: Unknown release version. Please replace with correct 'regression-RC-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
-    };
-  } else if (regressionStage === RegressionStage.Production) {
-    regressionLabel = {
-      name: `regression-prod-${releaseVersion || '*'}`,
-      color: '5319E7', // violet
-      description: releaseVersion ? `Regression bug that was found in production in release ${releaseVersion}` : `TODO: Unknown release version. Please replace with correct 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
-    };
-  } else {
-    regressionLabel = {
-      name: `regression-*`,
-      color: 'EDEDED', // grey
-      description: `TODO: Unknown regression stage. Please replace with correct regression label: 'regression-develop', 'regression-RC-x.y.z', or 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
-    };
-  }
-
+  const regressionLabel: Label = craftRegressionLabel(regressionStage, releaseVersion);
+
   let regressionLabelFound: boolean = false;
   const regressionLabelsToBeRemoved: {
     id: string;
@@ -374,3 +350,36 @@ function isIssueFromTeamNotUsingTemplates(
   }
   return false;
 }
+
+// This function crafts appropriate label, corresponding to regression stage and release version.
+function craftRegressionLabel(regressionStage: RegressionStage | undefined, releaseVersion: string | undefined): Label {
+  switch (regressionStage) {
+    case RegressionStage.Development:
+      return {
+        name: `regression-develop`,
+        color: '5319E7', // violet
+        description: `Regression bug that was found on development branch, but not yet present in production`,
+      };
+
+    case RegressionStage.Testing:
+      return {
+        name: `regression-RC-${releaseVersion || '*'}`,
+        color: '744C11', // orange
+        description: releaseVersion ? `Regression bug that was found in release candidate (RC) for release ${releaseVersion}` : `TODO: Unknown release version. Please replace with correct 'regression-RC-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
+      };
+
+    case RegressionStage.Production:
+      return {
+        name: `regression-prod-${releaseVersion || '*'}`,
+        color: '5319E7', // violet
+        description: releaseVersion ? `Regression bug that was found in production in release ${releaseVersion}` : `TODO: Unknown release version. Please replace with correct 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
+      };
+
+    default:
+      return {
+        name: `regression-*`,
+        color: 'EDEDED', // grey
+        description: `TODO: Unknown regression stage. Please replace with correct regression label: 'regression-develop', 'regression-RC-x.y.z', or 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`,
+      };
+  }
+}