Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filename and directory #46

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

JaroslawPokropinski
Copy link
Collaborator

Currently filename is always empty so downloading to with "save link as" or when name of the file cannot be inferred from url dont work. Chrome sets filename ot in oncreated but in first onchanged. This code waits for filename to be set before download. Additionaly added semicolons to prettier and ignored error with deleting file that is not finished downloading.

@gautamkrishnar
Copy link
Owner

Looks great 👍🏻 Thanks a lot for contributing @JaroslawPokropinski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants