Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add inputmode hint for mobile clients #302

Merged
merged 1 commit into from
Oct 21, 2019
Merged

feat: Add inputmode hint for mobile clients #302

merged 1 commit into from
Oct 21, 2019

Conversation

IvanBila
Copy link
Contributor

@IvanBila IvanBila commented Oct 6, 2019

Summary

This PR adds inputmode hint to the Cart list item and the Product Form, this change is aimed to improve user experience in mobile browsers, that way it displays the appropriate keyboard for the form input type being used(which in the particular case is numeric).

Preview

Current

IMG_2166

Proposed

inputmode-01_k2m78v

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Thank you so much 💜

@sidharthachatterjee sidharthachatterjee merged commit e2f90d3 into gatsbyjs:master Oct 21, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 21, 2019

Holy buckets, @IvanBila — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@IvanBila IvanBila deleted the add-inputmode branch October 28, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants