Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder package.json dependencies #297

Merged
merged 1 commit into from
Oct 21, 2019
Merged

chore: reorder package.json dependencies #297

merged 1 commit into from
Oct 21, 2019

Conversation

MatissJanis
Copy link
Contributor

When installing packages via yarn cli, they are auto-fixed. Which means that anytime a dev submits a PR with some version upgrade or new package added via yarn cli, the package.json file will be reordered.

This causes unnecessary noise in PRs.

The solution here is to fix the ordering. Subsequent PRs should not have this unnecessary change.

Example of the problem:
reorder

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks @MatissJanis 👍

@m-allanson m-allanson merged commit ffb3b3d into gatsbyjs:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants