Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use native Array.prototype.some() functionality #276

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

igeligel
Copy link
Contributor

@igeligel igeligel commented Jun 2, 2019

Type of change

  • Feature
  • Bugfix
  • Refactor

Description

Instead of creating a variable by looping over the full array we will use the native Array​.prototype​.some() functionality. More documentation of this functionality can be found on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some

@igeligel igeligel changed the title Update sticker pack id Use native Array.prototype.some() functionality Jun 2, 2019
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It looks like the gatsbyStickerPackID value doesn't match anymore (see #246), but this is a good refactor. Thanks!

@jlengstorf jlengstorf changed the title Use native Array.prototype.some() functionality refactor: use native Array.prototype.some() functionality Jun 17, 2019
@jlengstorf jlengstorf merged commit c624739 into gatsbyjs:master Jun 17, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 17, 2019

Holy buckets, @igeligel — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants