fix: hide free sticker notice when stickers are added to the shopping cart #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlengstorf
suggested changes
Apr 15, 2019
src/components/Cart/Cart.js
Outdated
| @@ -340,6 +341,12 @@ class Cart extends Component { | |||
| (total, item) => total + item.quantity, | |||
| 0 | |||
| ); | |||
|
|
|||
| checkout.lineItems.forEach(({title}) => { | |||
| if(title === 'Gatsby Sticker Pack') { | |||
There was a problem hiding this comment.
I think we may want to check for something other than the title — there's no guarantee we won't tweak the name of the product. Something like the slug or ID would probably be better here.
There was a problem hiding this comment.
@jlengstorf Gatsby Sticker Pack ID is having 140 characters length. Is it okay to use it ?
There was a problem hiding this comment.
That should be fine. Thanks!
There was a problem hiding this comment.
@jlengstorf Made changes to replace title with ID. Please can you verify. Thanks!
jlengstorf
changed the title
jlengstorf
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #246