Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a separate page for sizing/care instructions #89

Closed
4 tasks
jlengstorf opened this issue Jul 14, 2018 · 0 comments
Closed
4 tasks

Create a separate page for sizing/care instructions #89

jlengstorf opened this issue Jul 14, 2018 · 0 comments
Labels
🎯 Design enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jlengstorf
Copy link
Contributor

jlengstorf commented Jul 14, 2018 •
edited
Loading

The modal is great, but it presents some issues on mobile and also prevents people from linking to the content, so let's put that content on its own page.

Steps to complete this task:

  • Add a new page to the site
  • Add the content from the modal to the new page
  • Swap out modal links to for links to the new page
  • Remove any unused code and/or dependencies from the modal
@jlengstorf jlengstorf added bug Something isn't working 🎯 Design labels Jul 14, 2018
@jlengstorf jlengstorf mentioned this issue Jul 14, 2018
Closed
@jlengstorf jlengstorf changed the title Create a separate page for sizing/care instructions to use on mobile Create a separate page for sizing/care instructions Sep 5, 2018
@jlengstorf jlengstorf added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Sep 5, 2018
@marisamorby marisamorby mentioned this issue Sep 5, 2018
Closed
This was referenced Sep 9, 2018
Closed
Merged
@mikelax mikelax mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎯 Design enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlengstorf