[Bug] No way to close overlays for Materials & Fit and Care Instructions displays

[mikelax]

Overview

As a user, when I am browsing the product details page, ie. /product/dark-deploy-tee, If I click on either the Materials & Fit and Care Instructions Links a full page overlay is displayed. It takes up the full screen, but there is no way to dismiss or close the overlay to get back to the content you were looking at.

If you are going to stick with this as a modal (I think I saw some discussion of moving to a separate page, #89 ) then there needs to be an X close button.

[jlengstorf]

Oh, whoops. Yeah, that definitely needs to be fixed.

[isaac-martin]

@jlengstorf want me to take this on? Or are we migrating to a new page? as mentioned in #89

[jlengstorf]

So, looking at this, it actually does open a new page: https://store.gatsbyjs.org/product-details#materials-fit

The back button works as expected, so this isn't necessarily a bug, but more of a UX issue: it's not obvious that this is how it works.

Something that could be done to address this would be to add a button that uses the history object to navigate back to the product (similar to the "back to product list" button on the product page). If no previous product is found, it could default to "back to product listings".

Does that seem reasonable? If so, any takers to implement this?

[isaac-martin]

Yeah I can do this Jason. @jlengstorf

[jlengstorf]

Thank you!

[mikelax]

thanks @jlengstorf and @isaac-martin .
I think when I wrote up this ticket originally it was before the current design.
In the new (current) I agree the problem is just a UX issue where the user should be given some option (besides browser back button) to get back to the product they were just looking at.

I agree that either of these options would work:

• Add a Back to Product button
• Add a close (x) button right-aligned with page header that would "act" like a modal close button but would just navigate the user back to the previous page.

[jlengstorf]

Both options make sense. I think my preference would be for the back button. With the URL changing, an "X" could be really confusing if someone did notice that the URL changed. 😄

[gatsbot]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

[jlengstorf]

@isaac-martin hey, how’s it going? Have you had a chance to look at this? No pressure or anything — just let me know if you’re still planning to tackle this one so I can share it around if not.

Thanks!

[isaac-martin]

I've got a branch started, but have been hunting a new job so all spare time has been dedicated to that. Someone else could tackle it.

…

On Fri, Mar 1, 2019, 6:47 PM Jason Lengstorf ***@***.***> wrote: @isaac-martin <https://github.com/isaac-martin> hey, how’s it going? Have you had a chance to look at this? No pressure or anything — just let me know if you’re still planning to tackle this one so I can share it around if not. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#238 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIP6lqv_6bRrObn4pXuAoYUEJKw1Zaz6ks5vSbv-gaJpZM4Z74TY> .

[jlengstorf]

Sounds good, and good luck on your hunt!