feat(gatsby): Move connection out of sift #9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged #9416, can you update PR seems like our squashing on merge desynced this branch :( |
|
@pieh done |
Merged
pieh
reviewed
Oct 30, 2018
There was a problem hiding this comment.
Just minor things. We can skip it them if you feel like it would slow your progress on actual loki things. Just let me know and I'll merge as-is
I love moving createPageDependencies out of run-sift - it makes much more sense to have it in resolver than in run-sift
Co-Authored-By: Moocar <[email protected]>
Co-Authored-By: Moocar <[email protected]>
|
@pieh I'm definitely a fan of that new "Suggested change" feature :D. Should be good now |
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
**Builds on gatsbyjs#9416 . Merge that one before this** In additional to performing the queries, `run-sift.js` also currently converts the results into connections (if connection query). But as part of gatsbyjs#9338, we will be using `loki` to perform queries too. So we would need to duplicate the connection logic in both query engines. This PR pulls the connection logic out of run-sift and into `build-node-connections` which makes sense to me as the query engine doesn't need to know about connections. Only about whether it should return one result or many (thus the `firstOnly` flag). Another benefit is that the query engine no longer needs to understand page dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #9416 . Merge that one before this
In additional to performing the queries,
run-sift.jsalso currently converts the results into connections (if connection query). But as part of #9338, we will be usinglokito perform queries too. So we would need to duplicate the connection logic in both query engines.This PR pulls the connection logic out of run-sift and into
build-node-connectionswhich makes sense to me as the query engine doesn't need to know about connections. Only about whether it should return one result or many (thus thefirstOnlyflag).Another benefit is that the query engine no longer needs to understand page dependencies.