Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(www): Filter posts by date #9400

Merged
merged 7 commits into from
Nov 5, 2018
Merged

feat(www): Filter posts by date #9400

merged 7 commits into from
Nov 5, 2018

Conversation

jgierer12
Copy link
Contributor

Closes #9298

@jgierer12 jgierer12 requested a review from a team as a code owner October 25, 2018 17:18
@pieh
Copy link
Contributor

pieh commented Oct 26, 2018

Did you check if all current blog posts will have released field set to true? In gatsby we use moment library to parse date strings and in here You used Date class to do it and there might be some differences

@jgierer12
Copy link
Contributor Author

My bad, I didn't know moment was the preferred date library in this project. I did verify that all existing posts are marked as released. But to be sure, I will change it to moment.

@pieh
Copy link
Contributor

pieh commented Oct 26, 2018

My bad, I didn't know moment was the preferred date library in this project. I did verify that all existing posts are marked as released. But to be sure, I will change it to moment.

It's not "preferred" - it's just what is used in gatsby itself ( https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/schema/types/type-date.js ), so we definitely want to support same formats

edgarrmondragon
edgarrmondragon approved these changes Oct 29, 2018
View reviewed changes
Copy link

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

pieh
pieh approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgierer12, sorry for delay!

@pieh pieh merged commit bbf1f15 into gatsbyjs:master Nov 5, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 5, 2018

Holy buckets, @jgierer12 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@jgierer12 jgierer12 deleted the filter-www-posts branch November 6, 2018 15:42
lipis added a commit to lipis/gatsby that referenced this pull request Nov 6, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
20a6521 
* 'master' of github.com:gatsbyjs/gatsby: (63 commits)
  Update how-to-contribute.md to mention the style guide when writing blogs/tutorials (gatsbyjs#9742)
  Added  Tylermcginnis website (gatsbyjs#9619)
  Fix grammar and punctuation (gatsbyjs#9498)
  Fix typo of plugin authoring (gatsbyjs#9737)
  Authentication tutorial - small fixes (gatsbyjs#9738)
  chore: move run-sift (gatsbyjs#9549)
  docs: fix minor typo (gatsbyjs#9730)
  chore(release): Publish
  fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored (gatsbyjs#9720)
  fix: revert admin redirect (gatsbyjs#9728)
  fix: adjust page order to make nested matchPaths work (gatsbyjs#9719)
  feat(gatsby-plugin-sharp): cache base64 if possible (gatsbyjs#9059)
  chore(release): Publish
  fix(gatsby-plugin-offline): Serve the offline shell for short URLs + use no-cors for external resources (gatsbyjs#9679)
  chore(release): Publish
  fix: ensure babel-preset-gatsby can be used with unit tests (gatsbyjs#9629)
  feat(www): Filter posts by date (gatsbyjs#9400)
  fix(blog): azure blog post url date (gatsbyjs#9718)
  feat(blog): Add post on publishing to Azure (gatsbyjs#8868)
  Emphasize importance of promise return on source-plugin docs (gatsbyjs#9650)
  ...
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@jgierer12 @gpetrioli
feat(www): Filter posts by date (gatsbyjs#9400)
0f3b357 
Closes gatsbyjs#9298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgierer12 @pieh @edgarrmondragon