Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete doc since it was broken into smaller docs #9262

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

shannonbux
Copy link
Contributor

@shannonbux shannonbux commented Oct 19, 2018

This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar (commit 1af244b). If this PR gets merged I'll also delete this doc from the sidebar.

Taken from #8103:

Deploying

This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar. If this PR gets merged I'll also delete this doc from the sidebar.

Taken from #8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic #8736
- [x] Deploying to Heroku #8721 (PR)
- [x] Deploying to Now #8737
- [x] Deploying to GitLab Pages #8738
@shannonbux shannonbux requested a review from a team October 19, 2018 21:39
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely ready for deletion. I'd go ahead and make the sidebar change and merge!

@shannonbux shannonbux merged commit 5de6815 into master Oct 22, 2018
@shannonbux shannonbux deleted the delete-deploy-gatsby-doc branch October 22, 2018 22:59
jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar (commit gatsbyjs@1af244b). If this PR gets merged I'll also delete this doc from the sidebar.

Taken from gatsbyjs#8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic gatsbyjs#8736
- [x] Deploying to Heroku gatsbyjs#8721 (PR)
- [x] Deploying to Now gatsbyjs#8737
- [x] Deploying to GitLab Pages gatsbyjs#8738

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar (commit gatsbyjs@1af244b). If this PR gets merged I'll also delete this doc from the sidebar.

Taken from gatsbyjs#8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic gatsbyjs#8736
- [x] Deploying to Heroku gatsbyjs#8721 (PR)
- [x] Deploying to Now gatsbyjs#8737
- [x] Deploying to GitLab Pages gatsbyjs#8738

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants