Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out "Sourcing from the filesystem" stub article #8777

Merged
merged 13 commits into from
Oct 30, 2018

Conversation

caseychien
Copy link
Contributor

@caseychien caseychien commented Oct 4, 2018

This issue (#8730) is part of the content migration project #8103, which is meant to take existing content and repurpose it so it's easier to find in the docs.

@caseychien caseychien requested a review from a team October 4, 2018 05:52
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for getting started on this. It looks like the issue accidentally linked to the wrong tutorial section -- the section of tutorial copied over in this PR is about transforming markdown files (files that have already been sourced from the filesystem) This doc needs to address sourcing from the filesystem (I think this section of the tutorial is more related: https://www.gatsbyjs.org/tutorial/part-five/#source-plugins). Really sorry for that confusion!

I'd suggest the following steps:

  1. Read through the tutorial part five to see what might make sense to pull over.
  2. Start drafting the "Sourcing from the filesystem article" by coming up with the sections that make sense. Perhaps reference this recently merged doc: https://www.gatsbyjs.org/docs/sourcing-from-wordpress/.
  3. Within that structure, start pasting over and rewriting/repurposing the tutorial content to make sense as a doc (rather than reading as a tutorial).
  4. Review the additional resources listed in the issue description, to see if there's any additional detail that would make sense to pull into the doc as well.

The WordPress doc would be a great model for this effort!

@amberleyromo amberleyromo self-assigned this Oct 4, 2018
@caseychien
Copy link
Contributor Author

Hi @amberleyromo, thanks for the clarification! That makes much more sense, haha. I've migrated information from the correct tutorial this time and restructured the wording to make it more like a doc. If you could take another look, that would be awesome!


This guide assumes that you have a Gatsby project set up. If you need to set up a project, please reference the [Quick Start Guide](https://github.com/gatsbyjs/gatsby/tree/master/docs). In addition, it will be useful if you are familiar with Graph_i_QL, a tool that helps you structure your queries correctly.

## Introducing Graph_i_QL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this section is necessary for this doc. I'll explain further in a different comment in this review.

<p>Your browser does not support the video element.</p>
</video>

Here you poke around the built-in `Site` "type" and see what fields are available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, this makes no sense out of context of the tutorial.

local files, etc.

Source plugins fetch data from their source. E.g. the filesystem source plugin
knows how to fetch data from the file system. The WordPress plugin knows how to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think delete the last two sentences of this paragraph -- no need.

}
```

Save that and restart the gatsby development server. Then open up Graph_i_QL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not doing a step by step tutorial here -- I think what we could do here is

  1. show an example file that gets sourced
  2. show how to include the plugin (already done above)
  3. show an example GraphiQL query (without explaining GraphiQL).

When we use a resource like GraphiQL here, we can link directly to where it's explained in other sections. For example, "Not familiar with GraphiQL? Check out this section of the tutorial that introduces it."

Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Left some comments -- this is definitely a step in the right direction of moving away from the tutorial language to doc language 👍

"graph"). Each File object has the fields you queried for.


## What's coming next?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here -- this only makes sense in the context of the tutorial.

@amberleyromo
Copy link
Contributor

Hi @caseychien! Interested in tackling these comments and closing this out?

@caseychien
Copy link
Contributor Author

Hi @amberleyromo ! I am a bit busy with school, it would probably be best if someone else could finish cleaning up this doc

@amberleyromo
Copy link
Contributor

@shannonbux per #8777 (comment) I cleaned up this doc further and it's ready for review / any further tweaks you wish!

Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @caseychien!

@shannonbux shannonbux merged commit ef998ab into gatsbyjs:master Oct 30, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 30, 2018

Holy buckets, @caseychien — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@shannonbux
Copy link
Contributor

closes #8730

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
This issue (gatsbyjs#8730) is part of the content migration project [gatsbyjs#8103](gatsbyjs#8103), which is meant to take existing content and repurpose it so it's easier to find in the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants