[integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 29, 2018 13:57
* This fixes problems with APIs running earlier than waitForAPI * Also replace all instances of waitForRouteChange with waitForAPI
vtenfys
changed the title
Detect Cypress via window.Cypress, and store resolved APIs to a global variable, so that it works correctly even if the handler isn't setup when the API is called.
pieh
reviewed
Sep 30, 2018
| @@ -0,0 +1,32 @@ | |||
| let resolve = null | |||
| let promise = null | |||
There was a problem hiding this comment.
this doesn't have to be global - it's used just in waitForAPI
|
LGTM, only tiny thing we could do is to re-add |
DSchau
reviewed
Oct 1, 2018
| @@ -1 +1 @@ | |||
| // no-op | |||
| import "./commands" | |||
|
@pieh there's still the issue with the unnecessary global variable - I'm at Memiah this week so can you fix this please? |
DSchau
reviewed
Oct 2, 2018
| @@ -19,3 +19,11 @@ Cypress.Commands.add( | |||
| }) | |||
| } | |||
| ) | |||
|
|
|||
| Cypress.Commands.add( | |||
|
@davidbailey00 is there anything you still want to do in this PR or it's ready to merge? |
|
@pieh I think it's ready now! Personally I'm not sure if it's necessary to alias the old command since we never published this package, but there's no harm in doing so just to be safe :) |
|
@davidbailey00 @pieh merging :) |
|
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Oct 3, 2018
* 'master' of github.com:gatsbyjs/gatsby: (72 commits) fix: fix wording in plopfile (gatsbyjs#8735) fix: navigateTo deprecation message (gatsbyjs#8745) Add deploying-to-heroku.md (gatsbyjs#8721) fix(docs): Link to instructions on adding to plugin library (gatsbyjs#8686) updated gatsby-plugin-remove-trailing-slashes docs to include link re… (gatsbyjs#8720) feat(www/starters): Add TypeScript and Contentful starter (gatsbyjs#8704) fix(docs): fix typos in template doc (gatsbyjs#8692) feat(www): change chevron direction on sticky responsive sidebar (gatsbyjs#8664) chore(release): Publish [integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin (gatsbyjs#8641) chore(release): Publish fix(gatsby): add mjs config to webpack and resolve correctly (gatsbyjs#8717) feat(gatsby-plugin-netlify): add force option to createRedirect (gatsbyjs#8521) [www/starters] tweaks to fix DX for no GH token on www (gatsbyjs#8718) chore(release): Publish fix(gatsby-dev-cli): infer correct prefix from package path (gatsbyjs#8683) fix(www/starters): fix broken link to submission instructions (gatsbyjs#8715) chore(release): Publish feat(gatsby) : add createContentDigest helper (gatsbyjs#8687) feat: publish SendGrid case study blogpost (gatsbyjs#8592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the
waitForRouteChangeAPI and replaced it with a universal handler for all the Gatsby APIs - this will allow us to use any other APIs easily from Cypress, without having to implement custom handlers for each one.Currently this isn't working withworking in the last two commitsgatsby servesince the handlers aren't setup in time for the API calls, but it works withgatsby develop