[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) #7655

vtenfys · 2018-08-26T14:21:15Z

Changelog:

Upgrade all @babel/... packages from 7.0.0-beta.52 to 7.0.0-rc.3
- Until RC3, Babel had a bug where --ignore XYZ wasn't always working properly on Windows so extra failing tests were being generated
Update polyfill options in gatsby/cache-dir/__tests__/.babelrc to match API changes
Remove unnecessary polyfill from .babel-preset.js
Update preset options in babel-plugin-remove-graphql-queries/src/__tests__/index.js to match API changes
Update plugin options in gatsby/src/utils/babel-parse-to-ast.js to match API changes
Always output with \n line endings in gatsby-codemods/src/transforms/global-graphql-calls.js to fix the remaining Windows tests failing

vtenfys · 2018-08-26T14:24:23Z

Combined with PR #7607, this should fix all failing CI tests.

pieh · 2018-08-28T11:34:50Z

Looking good, right now we would probably want 7.0.0 as stable was released yesterday.

Other question is - should @babel/runtime-corejs2 be added to all packages that target browser? (i.e. gatsby-image)?

…ade-babel

vtenfys · 2018-08-28T12:50:29Z

@pieh I've just upgraded to v7 stable - tests seem to be running fine still :)

Re: corejs, Babel's options say that we need to change the dependency for packages which use the corejs option, so yes, we should replace the deps in packages which specify browser: true in their .babelrc. I'll see if I can work on this

vtenfys · 2018-08-28T15:25:41Z

@pieh I've just done all the dependency replacements, all tests passing locally (and hopefully on CI!) Please could you have a look and let me know if there's anything else which needs fixing?

jquense · 2018-08-28T16:30:58Z

I don't think we need to handle the core-js bits in packages since we polyfill the environments anyway.

I'd love to see this merged and get a release? this is not blocking a bunch of updates for me :)

jquense · 2018-08-28T16:32:24Z

packages/gatsby/src/utils/babel-parse-to-ast.js

+    [
+      `decorators`,
+      {
+        decoratorsBeforeExport: false,


maybe this should be true? the goal here is to be as permissive as possible

ok, I'll change this

jquense · 2018-08-28T16:33:42Z

.babel-preset.js

@@ -47,7 +47,7 @@ function preset(context, options = {}) {
        {
          // we are only polyfilling the node environment
          // so we need to enable the runtime replacements for the browser preset
-          polyfill: !!browser,
+          corejs: browser ? 2 : false,


present env should handle this i believe since it's got the selective polyfilling on already?

This might be the case but I was matching the previous behaviour - shall I remove this? And should I keep the changes in the last commit with the Babel runtime dependencies, or can these be left as just @babel/runtime?

I'd say we want to remove it if it doesn't break anything. The reason they added this was exactly to enable less unnecessary polyfilling so it'd be a win to change, even if it's not the same as previous behavior

Okay, I'll remove it and run through the tests. And shall I undo this commit too? (Tests were passing before I added this)

vtenfys · 2018-08-28T18:55:35Z

@jquense I've now removed the corejs option from .babel-preset.js and undone the unnecessary dependency changes - please let me know if this looks okay!

KyleAMathews · 2018-08-28T18:59:34Z

Deploy preview for using-contentful failed.

Built with commit c7858fe

https://app.netlify.com/sites/using-contentful/deploys/5b859a5ab13fb16c4f811804

KyleAMathews · 2018-08-28T19:00:04Z

Deploy preview for image-processing failed.

Built with commit c7858fe

https://app.netlify.com/sites/image-processing/deploys/5b859a59b13fb16c4f8117fb

vtenfys · 2018-08-28T20:17:24Z

AppVeyor failed because gatsby-dev-cli doesn't update dependencies - Gatsby built the site with the latest version of Babel, but the plugins resolve to packages inside Gatsbygram's own node_modules folder which has the old version of Babel, leading to incompatibilities.

Edit: same reason for the failed Netlify previews

jquense · 2018-08-29T12:03:47Z

package.json

-    "@babel/preset-flow": "7.0.0-beta.52",
-    "@babel/preset-react": "7.0.0-beta.52",
-    "@babel/runtime": "7.0.0-beta.52",
+    "@babel/core": "7.0.0",


we should add back the ^ on the versions here since we are out of beta's and there will be no breaking changes between v7 versions

jquense · 2018-08-29T12:04:02Z

packages/babel-plugin-remove-graphql-queries/package.json

@@ -3,8 +3,8 @@
  "version": "2.0.2-rc.0",
  "author": "Jason Quense <[email protected]>",
  "devDependencies": {
-    "@babel/cli": "7.0.0-beta.52",
-    "@babel/core": "7.0.0-beta.52"
+    "@babel/cli": "7.0.0",


ditto for all the babel deps actually

jquense

LGTM apart from the needed caret in the version ranges

KyleAMathews

Nice work!

KyleAMathews · 2018-08-29T14:34:15Z

package.json

-    "@babel/preset-flow": "7.0.0-beta.52",
-    "@babel/preset-react": "7.0.0-beta.52",
-    "@babel/runtime": "7.0.0-beta.52",
+    "@babel/core": "7.0.0",


KyleAMathews · 2018-08-29T14:35:43Z

packages/gatsby/src/utils/babel-parse-to-ast.js

+    [
+      `decorators`,
+      {
+        decoratorsBeforeExport: true,


are these required options now?

vtenfys · 2018-08-29T14:50:50Z

@KyleAMathews yep, those are required now. @jquense I'll add the ranged versions back later today and then hopefully this can be merged!

vtenfys · 2018-08-29T17:30:17Z

I've now added the caret ranges!

pieh · 2018-08-29T18:05:18Z

packages/gatsby-link/package.json

@@ -7,15 +7,16 @@
    "url": "https://github.com/gatsbyjs/gatsby/issues"
  },
  "dependencies": {
-    "@babel/runtime": "7.0.0-beta.52",
+    "@babel/runtime": "^7.0.0",
+    "@babel/runtime-corejs2": "^7.0.0",


This is not needed anymore, right?

Ah yep, I'll just remove that line

KyleAMathews

Thanks for your usual through/excellent work @davidbailey00!

… tests) (gatsbyjs#7655) * Upgrade to Babel 7.0.0-rc.3 * Update config options and snapshots * Fix tests on Windows * Fix React Babel preset and update snapshots * Upgrade Babel to 7.0.0 (stable) * Allow decorators before export * Remove unnecessary polyfill * Use caret ranges for Babel deps * Remove unneeded dependency

David Bailey added 3 commits August 26, 2018 14:51

Upgrade to Babel 7.0.0-rc.3

96e8e45

Update config options and snapshots

7f6db0a

Fix tests on Windows

84a9854

vtenfys requested a review from pieh August 26, 2018 14:23

Fix React Babel preset and update snapshots

053939d

vtenfys changed the title ~~Upgrade Babel from 7.0.0-beta.52 to 7.0.0-rc.3~~ [v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0-rc.3 Aug 26, 2018

vtenfys changed the title ~~[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0-rc.3~~ [v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0-rc.3 (fixing Windows tests) Aug 26, 2018

David Bailey added 2 commits August 28, 2018 13:16

Merge branch 'master' of https://github.com/gatsbyjs/gatsby into upgr…

556f284

…ade-babel

Upgrade Babel to 7.0.0 (stable)

6a172d5

vtenfys changed the title ~~[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0-rc.3 (fixing Windows tests)~~ [v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) Aug 28, 2018

jquense reviewed Aug 28, 2018

View reviewed changes

David Bailey added 2 commits August 28, 2018 19:47

Allow decorators before export

3f53a79

Remove unnecessary polyfill

c7858fe

jquense reviewed Aug 29, 2018

View reviewed changes

jquense previously approved these changes Aug 29, 2018

View reviewed changes

KyleAMathews previously approved these changes Aug 29, 2018

View reviewed changes

Use caret ranges for Babel deps

1e6aeab

vtenfys dismissed KyleAMathews’s stale review via 1e6aeab August 29, 2018 17:29

vtenfys dismissed jquense’s stale review via 1e6aeab August 29, 2018 17:29

pieh reviewed Aug 29, 2018

View reviewed changes

Remove unneeded dependency

0535dc4

KyleAMathews approved these changes Aug 29, 2018

View reviewed changes

KyleAMathews merged commit 1eea47d into gatsbyjs:master Aug 29, 2018

m-allanson mentioned this pull request Aug 29, 2018

Tests are babelified on Windows #6087

Closed

KyleAMathews mentioned this pull request Aug 31, 2018

v2 Can't resolve @babel/runtime/helpers/esm/* #7668

Closed

timothyjoh mentioned this pull request Dec 11, 2018

Windows only - Jest testing files are included and try to run in the codebase #10420

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) #7655

[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) #7655

vtenfys commented Aug 26, 2018 •

edited

Loading

vtenfys commented Aug 26, 2018

pieh commented Aug 28, 2018

vtenfys commented Aug 28, 2018

vtenfys commented Aug 28, 2018

jquense commented Aug 28, 2018

jquense Aug 28, 2018 •

edited

Loading

vtenfys Aug 28, 2018

jquense Aug 28, 2018

vtenfys Aug 28, 2018

jquense Aug 28, 2018

vtenfys Aug 28, 2018

vtenfys commented Aug 28, 2018

KyleAMathews commented Aug 28, 2018

KyleAMathews commented Aug 28, 2018

vtenfys commented Aug 28, 2018 •

edited

Loading

jquense Aug 29, 2018

KyleAMathews Aug 29, 2018

jquense Aug 29, 2018

jquense left a comment

KyleAMathews left a comment

KyleAMathews Aug 29, 2018

KyleAMathews Aug 29, 2018

vtenfys commented Aug 29, 2018

vtenfys commented Aug 29, 2018

pieh Aug 29, 2018

vtenfys Aug 29, 2018

KyleAMathews left a comment

[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) #7655

[v2] Upgrade Babel from 7.0.0-beta.52 to 7.0.0 stable (fixing Windows tests) #7655

Conversation

vtenfys commented Aug 26, 2018 • edited Loading

vtenfys commented Aug 26, 2018

pieh commented Aug 28, 2018

vtenfys commented Aug 28, 2018

vtenfys commented Aug 28, 2018

jquense commented Aug 28, 2018

jquense Aug 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vtenfys commented Aug 28, 2018

KyleAMathews commented Aug 28, 2018

KyleAMathews commented Aug 28, 2018

vtenfys commented Aug 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jquense left a comment

Choose a reason for hiding this comment

KyleAMathews left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vtenfys commented Aug 29, 2018

vtenfys commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KyleAMathews left a comment

Choose a reason for hiding this comment

vtenfys commented Aug 26, 2018 •

edited

Loading

jquense Aug 28, 2018 •

edited

Loading

vtenfys commented Aug 28, 2018 •

edited

Loading