Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing example of using mapping by ids #4619

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

sielay
Copy link
Contributor

@sielay sielay commented Mar 19, 2018

Based on question I raised here #4596 suggest adding more clear example of mapping by ids to the documentation.

Credit to @pieh for explanation.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Mar 19, 2018

Deploy preview for gatsbygram ready!

Built with commit 138b0b9

https://deploy-preview-4619--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Mar 19, 2018

Deploy preview for using-drupal ready!

Built with commit 138b0b9

https://deploy-preview-4619--using-drupal.netlify.com

@ghost ghost assigned m-allanson Mar 20, 2018
@ghost ghost added the review label Mar 20, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sielay! LGTM

@m-allanson m-allanson merged commit 3a196b5 into gatsbyjs:master Mar 21, 2018
@ghost ghost removed the review label Mar 21, 2018
@sielay sielay deleted the missing-mapping-doc branch March 21, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants