-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] improve how we load GraphQL query results in development/production (aka Ludicrous Mode) #4555
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e218c1f
Create placeholder JSON store
m-allanson 0894947
Rename
m-allanson 4ca7dda
Websocket placeholder
m-allanson cf55f6b
Push query results JSON over websockets
m-allanson 293f36a
More descriptive variable name
m-allanson 7e852cf
Fix queries being overwritten
m-allanson 2adaffe
Remove eslint-disable flag
m-allanson c03cc34
Remove junk
m-allanson ca50615
test require error fix for windows
pieh 460ca7d
dont require json data in sync-require
pieh f4c92e5
dont add layout data to json array multiple times
pieh e6239ee
initial async loading
pieh 4e064d7
revert saving json directly to public for now
pieh 1801fa7
updated production-app to sync with prop name change in ComponentRend…
pieh 53bc172
we load json data via json-loader component in develop and not handli…
pieh adc3ce1
hashes for json files
pieh 9008479
fix preloading, use xhr instead of fetch - for some reason can't forc…
pieh 3050620
dont use full paths in dataPath - remove static/d/ path and .json ext…
pieh 46e5235
Merge pull request #4635 from pieh/json-loader
m-allanson a3b6aee
Enable cached query results to be loaded
m-allanson 66e462c
Don't dump all query results out to the client
m-allanson 8196649
Merge pull request #4658 from m-allanson/load-develop-query-results
m-allanson 7602a73
Merge remote-tracking branch 'upstream/v2' into json-loader-w4
pieh f0b3b0c
fix preload link to json data
pieh c268376
Merge remote-tracking branch 'upstream/v2' into json-loader
pieh 2d9e286
remove not used function
pieh 95fcd4a
remove more not used code
pieh 20252dc
Update to latest webpack/mini-css-extract-plugin
KyleAMathews 44797c3
don't write new (a)sync-requires.js if components didn't change (#4759)
pieh 467a792
create just one websocket client (#4763)
pieh dd442c7
Filter out duplicate query jobs and create secondary queue for jobs i…
KyleAMathews abcb58c
[json-loader] Don't emit new file node until previous is finished pro…
KyleAMathews e374818
[json-loader] Only log file events if we're past bootstrap (#4826)
KyleAMathews 62754de
[json-loader] dont recompile on data change - part 2 (#4837)
pieh 4a09f74
[json-loader] develop - reading results from file improvments (#4850)
pieh 868ef8b
Add query prioritization based on what page(s) user(s) are on
KyleAMathews b4fdecb
Add initial forward slash
KyleAMathews 1bb7cc4
Actually this is how we add back the initial forward slash
KyleAMathews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this moved elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal probably shouldn't be in this PR - this is dead code even in master - https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/cache-dir/root.js#L120
addNotFoundRoute
is defined but not used anywhere and so isnoMatch
after removal of previous function