-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(webpack loaders) manage images links with query parameters #398
(webpack loaders) manage images links with query parameters #398
Conversation
When a image link contains query parameter, webpack doesn't handle it. e.g. with a link to an .svg file -> .../file.svg?v=1 the file will not be handle by webpack, and the user will get an error like below. ``` Module parse failed: /.../node_modules/font-awesome/fonts/fontawesome-webfont.svg?v=4.6.3 Unexpected token (1:0) You may need an appropriate loader to handle this file type. ```
Oh cool! Thanks! Unless someone sees a problem with this, I'll merge it later. Seems like a reasonable tweak. |
@KyleAMathews Thanks you. It is related to the same issue on |
Haha "Create React App" peeps are the Webpack DX prototypers of the internet ❤️ |
Thanks, could you bump the version ? :) |
Waiting for tests to finish on #399 |
@KyleAMathews Ok ;-) great. |
0.12.4 is out |
Hiya @tsunammis! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
When a image link contains query parameter, webpack doesn't
handle it.
e.g. with a link to an .svg file -> .../file.svg?v=1
the file will not be handle by webpack, and the user will get
an error like below.