Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin cheerio #39066

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: pin cheerio #39066

merged 1 commit into from
Aug 26, 2024

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Aug 22, 2024

Description

cheerio recently was released as stable with set of breaking changes that previous RC version didn't have. One of the main ones is related to this cheeriojs/cheerio#3986 (comment) in

which currently released wordpress plugin cause problems for users that are installing plugin manually now or tried to regenerate lock file / updated packages.

Because stable version requires node@>=18.17, it's not something that can be merged without the need to bump major for lot of packages, so instead of migrating wordpress plugin import, we are pinning to last available version before required node version was bumped. 1.0.0-rc.12 version I pinned to was also the version that has been in used by gatsby packages for over 2 years, so this pinning just stabilize it.

Underlying reason for ci/circleci: integration_tests_gatsby_cli failure is

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.17". Got "18.0.0"

Which is one of the things this PR is addressing, but because that test only use things actually released to npm and not current state of the repo it's not something that can be easily/quickly changed.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 22, 2024
@pieh pieh force-pushed the fix/cheerio-default-export branch from 5e5a37e to cc93098 Compare August 22, 2024 16:21
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 23, 2024
@pieh pieh marked this pull request as ready for review August 23, 2024 09:24
@pieh pieh merged commit e2c3a86 into master Aug 26, 2024
33 of 35 checks passed
@pieh pieh deleted the fix/cheerio-default-export branch August 26, 2024 09:47
pieh added a commit that referenced this pull request Aug 26, 2024
(cherry picked from commit e2c3a86)
pieh added a commit that referenced this pull request Aug 26, 2024
(cherry picked from commit e2c3a86)

Co-authored-by: Michal Piechowiak <[email protected]>
@pieh
Copy link
Contributor Author

pieh commented Aug 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

2 participants