fix: pin cheerio #39066
Merged
fix: pin cheerio #39066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
fix/cheerio-default-export
branch
from
5e5a37e
to
cc93098
Compare
pieh
removed
the
status: triage needed
orinokai
approved these changes
Aug 23, 2024
pieh
added a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit e2c3a86)
pieh
added a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit e2c3a86) Co-authored-by: Michal Piechowiak <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cheeriorecently was released as stable with set of breaking changes that previous RC version didn't have. One of the main ones is related to this cheeriojs/cheerio#3986 (comment) ingatsby/packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/process-node.js
Line 8 in 33f18ba
Because stable version requires
node@>=18.17, it's not something that can be merged without the need to bump major for lot of packages, so instead of migrating wordpress plugin import, we are pinning to last available version before required node version was bumped.1.0.0-rc.12version I pinned to was also the version that has been in used by gatsby packages for over 2 years, so this pinning just stabilize it.Underlying reason for
ci/circleci: integration_tests_gatsby_clifailure isWhich is one of the things this PR is addressing, but because that test only use things actually released to npm and not current state of the repo it's not something that can be easily/quickly changed.